Wireshark-commits: [Wireshark-commits] master 39c3a79: Check if mask_greatest_bit_offset is within
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Oct 2014 01:45:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39c3a794d889e1439c473f9066e9a36d190b7589
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

39c3a79 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Check if mask_greatest_bit_offset is within limits.
    
    The result of the '>>' expression is undefined if mask_greatest_bit_offset = 0.
    
    Change-Id: I15b094a5220a5075878bad65ab0b8c5279e80e8a
    Reviewed-on: https://code.wireshark.org/review/4723
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4963d99   Eliminate proto_tree_add_text from packet-cdp.c
    adds  39c3a79   Check if mask_greatest_bit_offset is within limits.


Summary of changes:
 epan/proto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)