Wireshark-commits: [Wireshark-commits] master-1.10 19141fe: MIPv6: Mobility Option Mobile Node Link
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Oct 2014 09:26:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19141fe5142efe36db63c31f92928e7aea14d162
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

19141fe by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data
    
    there's a single IPv6 packet with Mobile Node Link Layer Identifier mobility option.
    The option's data length is 9 but and since the Reserved field takes 2 bytes, the Link Layer Identifier field should take 7 bytes.
    However, the Link Layer Identifier field is read until the end of the packet, which is 519 bytes.
    
    Bug:10578
    Change-Id: I518de7f6b75e5b749cb029845fd4846954ca6d0e
    Reviewed-on: https://code.wireshark.org/review/4818
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 51f496220322ac518d9485afe030d0568fdae080)
    Change-Id: I518de7f6b75e5b749cb029845fd4846954ca6d0e
    Reviewed-on: https://code.wireshark.org/review/4824
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  82828ed   MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field
    adds  19141fe   MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data


Summary of changes:
 epan/dissectors/packet-mip6.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)