Wireshark-commits: [Wireshark-commits] master 1de3a5b: Check for printable ASCII in an ENBName.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Oct 2014 00:22:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1de3a5bc4932b1a18c931a1c1cea8d1cf5870dd2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1de3a5b by Guy Harris (guy@xxxxxxxxxxxx):

    Check for printable ASCII in an ENBName.
    
    I'm not sure why the check is only for alphabetical characters; if
    that's correct, change this to use g_ascii_isalpha, and change
    is_printable_ascii to is_ascii_alpha or something such as that.
    
    Don't use ctype.h routines, as they are locale-dependent.
    
    Change-Id: I61d0672350d35ad918e95d7e96ed5dd263102da9
    Reviewed-on: https://code.wireshark.org/review/4805
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9f2a878   Get rid of unnecessary includes of ctype.h.
    adds  1de3a5b   Check for printable ASCII in an ENBName.


Summary of changes:
 asn1/s1ap/packet-s1ap-template.c |    1 -
 asn1/s1ap/s1ap.cnf               |   10 +++++-----
 epan/dissectors/packet-s1ap.c    |   25 ++++++++++++-------------
 3 files changed, 17 insertions(+), 19 deletions(-)