Wireshark-commits: [Wireshark-commits] master-1.10 988cb32: Don't use ctype.h routines.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 20:51:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=988cb32bca7f6c160e047922fdfe5a4547cb7f39
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

988cb32 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use ctype.h routines.
    
    That avoids locale dependency and handles possibly-signed chars (which
    we weren't doing before).
    
    (cherry picked from commit 5bfde7c6386b56db80fec85e2ca7dc1d271b461c)
    
    Change-Id: Ia20fe28a77b136e0860cffa43cc36d994af04f13
    Reviewed-on: https://code.wireshark.org/review/4783
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  612491b   isdigit -> g_ascii_isdigit to handle 8-bit bytes correctly.
    adds  988cb32   Don't use ctype.h routines.


Summary of changes:
 wiretap/catapult_dct2000.c |   27 +++++++++++++--------------
 wiretap/cosine.c           |    3 +--
 wiretap/daintree-sna.c     |    9 ++++-----
 wiretap/dbs-etherwatch.c   |   19 +++++++++----------
 wiretap/dct3trace.c        |    3 +--
 wiretap/iseries.c          |    5 ++---
 wiretap/netscreen.c        |    5 ++---
 wiretap/vms.c              |   11 +++++------
 8 files changed, 37 insertions(+), 45 deletions(-)