Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 23b92bb: Better fix - just check that the upper and lower nibbles ar

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23b92bbac2546ea58b05ede324a6ad99371c1308
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

23b92bb by Guy Harris (guy@xxxxxxxxxxxx):

    Better fix - just check that the upper and lower nibbles are >= 0xA.
    
    An unsigned 8-bit integer is always <= 0xFF; that was the cause of the
    warning.
    
    To see whether a byte, when represented as hex, has letters for its
    upper and lower nibbles, just check whether both nibbles are >= 0xA.
    Cast the extracted nibbles to make sure there's no sign-extension.
    
    Change-Id: If4c7717a5d2fe341c02e9309ee6b89973a6ac292
    Reviewed-on: https://code.wireshark.org/review/4739
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f6bc6f957a13471fecb4ce0a31ca09f30cdde44f)
    Reviewed-on: https://code.wireshark.org/review/4740
    

Actions performed:

    from  1e09b78   gchar is not guaranteed to be signed; use gint8.
    adds  23b92bb   Better fix - just check that the upper and lower nibbles are >= 0xA.


Summary of changes:
 epan/ftypes/ftype-pcre.c |   22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)