Wireshark-commits: [Wireshark-commits] master 50add40: Fix some more "char is unsigned" issues, and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 18:17:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=50add40a2da49178fd784b063e44d59208d40d02
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

50add40 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some more "char is unsigned" issues, and a possible "char is signed" one.
    
    C neither guarantees that char is signed nor that it's unsigned.  Make
    the str_to_nibble tables arrays of gint8, to make sure they can hold
    numbers between 0 and 15 as well as -1.  Cast gchar to guchar, not int,
    when using it as a subscript into that array, so that the subscripts are
    in the range 0 to 255, not -128 to 127.
    
    Change-Id: Ib85de5aa4e83ae9efd808c78ce3f86f45b4a3f2a
    Reviewed-on: https://code.wireshark.org/review/4734
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  353f625   Fix issues in some ARM compilers, due to char being unsigned?
    adds  50add40   Fix some more "char is unsigned" issues, and a possible "char is signed" one.


Summary of changes:
 epan/strutil.c               |    8 ++++----
 epan/wslua/wslua_internals.c |    8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)