Wireshark-commits: [Wireshark-commits] master a34b252: Replace proto_tree_add_text with proto_tree_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Oct 2014 14:48:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a34b2526c67cd5c2fdf78b17defc0ce706f9eb10
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a34b252 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Replace proto_tree_add_text with proto_tree_add_subtree(_format) in generated files
    
    As requested by Michael Mann, all occurences of proto_tree_add_text/proto_item_add_subtree are replaced with proto_tree_add_subtree(_format) in the generated files. Our generator templates have also been updated accordingly.
    
    Change-Id: I49ddd664dffef4b3ceda77edd1b2d7e01da363f3
    Reviewed-on: https://code.wireshark.org/review/4725
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d347b72   Don't try to compute time stamps for files from Packet Builder.
    adds  a34b252   Replace proto_tree_add_text with proto_tree_add_subtree(_format) in generated files


Summary of changes:
 plugins/opcua/opcua_complextypeparser.c |  545 +++++++++++++++----------------
 plugins/opcua/opcua_serviceparser.c     |  318 +++++++++---------
 2 files changed, 431 insertions(+), 432 deletions(-)