Wireshark-commits: [Wireshark-commits] master 371e4ae: Eliminate some proto_tree_add_text from GSM
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Oct 2014 19:16:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=371e4ae1c787bfbfd292fbf2474624241ea942f9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

371e4ae by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate some proto_tree_add_text from GSM dissectors (so now there are no dissectors with 100+ proto_tree_add_text calls).
    
    Add tfs_allocated_by_receiver_sender to tfs.h because it seems "popular" enough.
    
    Change-Id: I478461d9b951a2c3e3aec6aaf996d95ba2c0feee
    Reviewed-on: https://code.wireshark.org/review/4708
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9b7ee18   Typos in source code and in README.qt
    adds  371e4ae   Eliminate some proto_tree_add_text from GSM dissectors (so now there are no dissectors with 100+ proto_tree_add_text calls).


Summary of changes:
 epan/dissectors/packet-ansi_a.c       |    8 +-
 epan/dissectors/packet-gsm_a_bssmap.c |    2 -
 epan/dissectors/packet-gsm_a_dtap.c   |    4 +-
 epan/dissectors/packet-gsm_a_rp.c     |  119 ++++-----
 epan/dissectors/packet-gsm_a_rr.c     |  439 +++++++++++++++++----------------
 epan/tfs.c                            |    1 +
 epan/tfs.h                            |    2 +
 7 files changed, 279 insertions(+), 296 deletions(-)