Wireshark-commits: [Wireshark-commits] master 8cc7b0d: Fixed missing padding. Fixed ENC_NA/ENC_BIG_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Oct 2014 10:37:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cc7b0d6cfe27730499c5877b766becdb4a9c6c5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8cc7b0d by Joseph Huffman (jhuffman@xxxxxxxxxxxxxx):

    Fixed missing padding. Fixed ENC_NA/ENC_BIG_ENDIAN errors.
    
    There was no tree items for padding in the many instances where there were
    bytes added to make certain data types align on even boundaries of 2, 4, or
    8 bytes. These instances now show up as "Padding" in the display.
    
    There were many instances where ENC_NA was used for fields of more than one
    byte. This wasn't noticed before because ENC_NA was ENC_BIG_ENDIAN for
    historical reasons and all these fields are big endian fields.
    
    Change-Id: Iabadd46eacc9ceb8ca85f4a5ba42b6583375c5f0
    Signed-off-by: Joseph Huffman <jhuffman@xxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/4413
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8d0becd   Aliging PIM hello message type to IANA in order to fix BUG 10231
    adds  8cc7b0d   Fixed missing padding. Fixed ENC_NA/ENC_BIG_ENDIAN errors.


Summary of changes:
 epan/dissectors/packet-alljoyn.c |   80 +++++++++++++++++++++++++++++++++++---
 1 file changed, 74 insertions(+), 6 deletions(-)