Wireshark-commits: [Wireshark-commits] master ed0b19b: Make boolean bitmask type 64-bit wide
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Oct 2014 14:15:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed0b19b94bf07056b5e0cfe64d4d05c3ebae801a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ed0b19b by Daniel Mack (daniel@xxxxxxxxxx):

    Make boolean bitmask type 64-bit wide
    
    There are protocols out there that have 64-bit wide bit mask fields, so
    make the internal representation and bitfield decoders 64-bit aware.
    
    For this, the ws_ctz() fallback and bits_count_ones() have to be tweaked
    slightly.
    
    Change-Id: I19237b954a69c9e6c55864f281993c1e8731a233
    Reviewed-on: https://code.wireshark.org/review/4158
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  29afac2   Add support for NTTIME_hyper and NTTIME_1sec
    adds  ed0b19b   Make boolean bitmask type 64-bit wide


Summary of changes:
 doc/README.dissector        |    4 +--
 epan/ftypes/ftype-integer.c |    8 ++---
 epan/proto.c                |   70 ++++++++++++++++++++++++++++++-------------
 epan/proto.h                |    2 +-
 epan/to_str.c               |   12 ++++----
 epan/to_str.h               |    6 ++--
 ui/gtk/bytes_view.c         |    2 +-
 ui/gtk/bytes_view.h         |    2 +-
 ui/gtk/packet_panes.c       |   25 +++++++++-------
 ui/gtk/packet_win.c         |    2 +-
 wsutil/bits_count_ones.h    |   12 ++++----
 wsutil/bits_ctz.h           |   26 ++++++++++++----
 12 files changed, 109 insertions(+), 62 deletions(-)