Wireshark-commits: [Wireshark-commits] master 7e49f06: wtap_file_read_till_separator() can return v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Oct 2014 10:22:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e49f061900e4c139fbdb3ee80f199f603282751
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e49f06 by Guy Harris (guy@xxxxxxxxxxxx):

    wtap_file_read_till_separator() can return values other than 1 on success.
    
    It returns the length of the string it read, so only treat 0 and -1 as
    errors.  (0 either means "EOF" or "string is zero length", but this is
    only in the code that reads numbers, and a number needs at least 1
    digit, so both EOF and "zero-length string" mean "this isn't a valid
    Peek tagged file".)
    
    Change-Id: Ib83eb2f1e53d912a2138be01480e2b464cf936db
    Reviewed-on: https://code.wireshark.org/review/4591
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f5b06c5   Fix some more int-to-enum conversion complaint.
    adds  7e49f06   wtap_file_read_till_separator() can return values other than 1 on success.


Summary of changes:
 wiretap/peektagged.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)