Wireshark-commits: [Wireshark-commits] master 58cc452: Eliminate proto_tree_add_text from packet-lm
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Oct 2014 19:47:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58cc452d6f3fd6e9b3441796574fdd50e9565257
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

58cc452 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-lmp.c
    
    Also "refactored" a few fields into proto_tree_add_bitmask calls.
    
    Change-Id: I3a222b38e1992943d6ee4bd300026bc28c5bbb78
    Reviewed-on: https://code.wireshark.org/review/4575
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  608207f   Add Dissection of MA packets over UDP
    adds  58cc452   Eliminate proto_tree_add_text from packet-lmp.c


Summary of changes:
 epan/dissectors/packet-lmp.c |  552 +++++++++++++++++++-----------------------
 1 file changed, 251 insertions(+), 301 deletions(-)