Wireshark-commits: [Wireshark-commits] master 39b2814: Eliminate proto_tree_add_text from packet-nb
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Oct 2014 17:13:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39b281461d6113134bd5203bca9b4ca27b146cda
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

39b2814 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-nbns.c
    
    Some other cleanup while in the neighborhood.  Not sure the all the proto_tree_add_expert calls are needed after each field (having implicit bounds error thrown should be sufficient), but left them in there.
    
    Change-Id: I3ca75ec9f51ccbed6b6ca792789daa8e7cebf34a
    Reviewed-on: https://code.wireshark.org/review/4574
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1c51075   [BACnet][trivial] change strings as per Bug 9640
    adds  39b2814   Eliminate proto_tree_add_text from packet-nbns.c


Summary of changes:
 epan/dissectors/packet-dns.c  |   11 +-
 epan/dissectors/packet-dns.h  |    2 +-
 epan/dissectors/packet-nbns.c |  486 ++++++++++++++++++++++-------------------
 3 files changed, 261 insertions(+), 238 deletions(-)