Wireshark-commits: [Wireshark-commits] master 1280015: [iSCSI] Fix incorrect heuristic.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Oct 2014 20:53:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12800157d6b813768cd5adfef4ce3c5c2eec81c5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1280015 by Anish Bhatt (anish@xxxxxxxxxxx):

    [iSCSI] Fix incorrect heuristic.
    
    The only valid check for Expected Data Transfer Length is :
    R and W  MUST  NOT both be 0 when the Expected Data Transfer Length and/or
    Bidirectional Read Expected Data Transfer Length are not 0
    
    Bug #10469
    Change-Id: I5503a5ad524c4e237b143696fc8eda895bcb9172
    Reviewed-on: https://code.wireshark.org/review/4514
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6831652   asn2wrs: Added support for #.SYNTAX_NEW
    adds  1280015   [iSCSI] Fix incorrect heuristic.


Summary of changes:
 epan/dissectors/packet-iscsi.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)