Wireshark-commits: [Wireshark-commits] master 683d657: PIDL (DCERPC): fix Assigned value is garbage
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Oct 2014 01:13:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=683d657d4977487c073777f156938d6970e2f08b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

683d657 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer
    
    packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined
    packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined
    packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined
    packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined
    packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value
    packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized]
    
    Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f
    Reviewed-on: https://code.wireshark.org/review/4478
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  de13887   idl2wrs (DCERPC DRSUAPI): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  683d657   PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer


Summary of changes:
 epan/dissectors/packet-dcerpc-dfs.c        |    2 +-
 epan/dissectors/packet-dcerpc-dnsserver.c  |    2 +-
 epan/dissectors/packet-dcerpc-frstrans.c   |    2 +-
 epan/dissectors/packet-dcerpc-lsa.c        |    2 +-
 epan/dissectors/packet-dcerpc-nspi.c       |    6 +++---
 epan/dissectors/packet-dcerpc-nspi.h       |    2 +-
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |    2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)