Wireshark-commits: [Wireshark-commits] master 2079592: Update capture_opts in extcap_cleanup().
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 4 Oct 2014 11:17:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20795925ffb2f9687e960de8d6798e53482cb175
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2079592 by Tomasz Moń (desowin@xxxxxxxxx):

    Update capture_opts in extcap_cleanup().
    
    This fixes redundant extcap_pid handle close that could occur in
    capture_opts_del_iface() which resulted in unhandled exception on
    Windows.
    
    Change-Id: I06b680fcb65cd6fd854a25fb1b01248dce3251a1
    Reviewed-on: https://code.wireshark.org/review/4447
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  06926ae   Wait for extcap to connect to pipe on Windows.
    adds  2079592   Update capture_opts in extcap_cleanup().


Summary of changes:
 capture_opts.c |    8 ++++----
 capture_opts.h |    8 +++++++-
 extcap.c       |   32 +++++++++++---------------------
 3 files changed, 22 insertions(+), 26 deletions(-)