Wireshark-commits: [Wireshark-commits] master b2d81a2: Remove proto_tree_add_text_valist from disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2014 06:21:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2d81a2a8d1e760bd57bdde58a44c686acaee12c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b2d81a2 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove proto_tree_add_text_valist from dissectors.
    
    The only remaining call to proto_tree_add_text_valist is in expert.c.  Suggestions welcome on how to make it "private" enough so dissectors can't use it.
    
    Change-Id: I1b70789bd01a857c3ac06d198667aeb59c4d1be9
    Reviewed-on: https://code.wireshark.org/review/4333
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  45fb377   Fix lua bindings to handle timestamp precision changes
    adds  b2d81a2   Remove proto_tree_add_text_valist from dissectors.


Summary of changes:
 epan/dissectors/Makefile.common |    1 -
 epan/dissectors/packet-esis.c   |  161 ++++++++++++++-----------------------
 epan/dissectors/packet-esis.h   |   59 --------------
 epan/dissectors/packet-nlsp.c   |  168 +++++++++++++++++----------------------
 4 files changed, 135 insertions(+), 254 deletions(-)
 delete mode 100644 epan/dissectors/packet-esis.h