Wireshark-commits: [Wireshark-commits] master e9c4217: Don't change the packet list column precisio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Sep 2014 08:02:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e9c4217dca91e3a403af9b16a317dba2e8a20559
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e9c4217 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't change the packet list column precision in taps.
    
    The only place where the packet list column precision should be set is
    in the code for the column precision menu item, the code for the recent
    file item for that precision, and, if we were to provide it, code for a
    command-line optpion to set it.  It's not up to some tap to change it.
    
    Change-Id: I547e606fb346b4c21674a66e883cbbe382055a37
    Reviewed-on: https://code.wireshark.org/review/4336
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0b5fb7   PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  e9c4217   Don't change the packet list column precision in taps.


Summary of changes:
 ui/cli/tap-comparestat.c |    2 --
 ui/gtk/compare_stat.c    |    4 ----
 2 files changed, 6 deletions(-)