Wireshark-commits: [Wireshark-commits] master-1.12 4c49881: Fix a record size check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Sep 2014 07:52:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c498810e4a6a700b316b3dd8c4b4df4c36c4938
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4c49881 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix a record size check.
    
    It was being checked against the wrong value, so some invalid records
    passed the check.
    
    Also, change one comparison (rec_size is in the range [0, 65535], even
    though it's in an int, so we can safely cast it to guint) and fix the
    metadata length value when reading Ethernet packets.
    
    Bug: 10495
    Change-Id: I2ce5c93fe50d836ec0accfcdef31654ba6b5b7c7
    Reviewed-on: https://code.wireshark.org/review/4278
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/4279
    

Actions performed:

    from  f91784a   radcom_read_rec() should always read from the file specified by the fh argument.
    adds  4c49881   Fix a record size check.


Summary of changes:
 wiretap/vwr.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)