Wireshark-commits: [Wireshark-commits] master 42018cf: pcapng: respect the fact that wblock->data i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Sep 2014 01:30:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42018cf08a7512b9d2dc142158b00078ff274e0b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

42018cf by Evan Huus (eapache@xxxxxxxxx):

    pcapng: respect the fact that wblock->data is a union
    
    Make sure to zero the *entire* thing, and only access it as a given type when
    that's the type indicated by the (non-union) type field.
    
    Bug: 10498
    Change-Id: I3e94a9c5d399d3ee4aedcd49f1aa2d7678ecf7ce
    Reviewed-on: https://code.wireshark.org/review/4273
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  a1604bd   test: add decryption test for isakmp with certificates
    adds  42018cf   pcapng: respect the fact that wblock->data is a union


Summary of changes:
 wiretap/pcapng.c |   27 +++++++++------------------
 1 file changed, 9 insertions(+), 18 deletions(-)