Wireshark-commits: [Wireshark-commits] master-1.12 58dbd92: The heuristic for T.125 per is too week
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Sep 2014 18:55:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58dbd92d783013a8d471bbc42a6515530e0cb3fe
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

58dbd92 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    The heuristic for T.125 per is too week and we do not have a PER dissector
    for T.125 so remove the test.
    Remove unused hf entries.
    Fixes bug 10350.
    
    Change-Id: If28de7877388c669082f8c8a21dd63107d417fbf
    Reviewed-on: https://code.wireshark.org/review/3458
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 892703f9181fe98e87926c70b348b6df3e69c82e)
    Reviewed-on: https://code.wireshark.org/review/4268
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  0942d2c   Trying to create and use an empty tvb now throws an exception.  Just pass current tvb to mac-lte dissector.
    adds  58dbd92   The heuristic for T.125 per is too week and we do not have a PER dissector for T.125 so remove the test. Remove unused hf entries. Fixes bug 10350.


Summary of changes:
 asn1/t125/packet-t125-template.c |   32 --------------------------------
 epan/dissectors/packet-t125.c    |   25 ++-----------------------
 2 files changed, 2 insertions(+), 55 deletions(-)