Wireshark · Wireshark-commits: [Wireshark-commits] master d3cd4c4: Qt: Re-enable menu icons.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3cd4c4b28d66d5d41a6c6a10bdf6f96187108a7
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d3cd4c4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Re-enable menu icons.
    
    The GNOME HIG says "Where a corresponding toolbar icon exists, a menu
    icon should mirror its design." The Windows and OS X HIGs say that you
    should use them for common or familiar actions but otherwise avoid
    clutter. I think icons in the "File" menu look like crap. Try to strike
    a balance.
    
    Use the 16x16 application icon for both the main web site and the wiki
    since that's the favicon used on both sites.
    
    Assume that "Reload" isn't used very often and remove it from the
    toolbar.
    
    Don't use a menu icon for the about box.
    
    Other minor fixups.
    
    Change-Id: I855211c218d266c2e9ed5acbe05a08750ab6d157
    Reviewed-on: https://code.wireshark.org/review/4246
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  be32460   Make peekclassic_read_packet_v56() more like the _v7 version.
    adds  d3cd4c4   Qt: Re-enable menu icons.


Summary of changes:
 image/toolbar.qrc                   |   28 ++--------------------------
 image/toolbar/16x16/go-next.svg.png |  Bin 492 -> 0 bytes
 ui/qt/capture_interfaces_dialog.ui  |    6 +-----
 ui/qt/main_window.cpp               |   11 +++++------
 ui/qt/main_window.ui                |   34 +++++++++++++++++-----------------
 ui/qt/wireshark_application.cpp     |    2 --
 6 files changed, 25 insertions(+), 56 deletions(-)
 delete mode 100644 image/toolbar/16x16/go-next.svg.png