Wireshark-commits: [Wireshark-commits] master 19d55ca: fix-encoding-args.pl: Don't use a feature av
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Sep 2014 14:32:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19d55ca5a2f83b0711dbcf6b7ea5393d0dd534b1
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

19d55ca by Bill Meier (wmeier@xxxxxxxxxxx):

    fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14
    
    Specifically: Window msys git uses an earlier version of Perl (5.8) and thus
    	      invoking fix-encoding-args.pl in the pre-commit hook script
    	      gives a Perl syntax error.
    
    See https://code.wireshark.org/review/4172 for details
    
    (Also see following for Perl info:
     http://www.perl.com/pub/2011/05/new-features-of-perl-514-non-destructive-substitution.html)
    
    Change-Id: I95a222eaa31942cc6e873ffbde57c5fa5bd2a625
    Reviewed-on: https://code.wireshark.org/review/4245
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  aac1cb2   Bluetooth: Handle LE ACL session
    adds  19d55ca   fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14


Summary of changes:
 tools/fix-encoding-args.pl |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)