Wireshark-commits: [Wireshark-commits] master 5e231d1: Fix wslua_filehandler_open() to work as wire
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 22:52:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e231d1d9cb90471344f0fff80f3cea0a57e718b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5e231d1 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix wslua_filehandler_open() to work as wiretap open routines should.
    
    They should return 1 on success, -1 on error, and 0 if there was no
    error but the file isn't one of the type for the routine.  They must not
    return any other value.  If they return -1, they must set *err.
    
    Change-Id: I0f1e1675b4cc8f0214ad67a23de0e4ecb09cabea
    Reviewed-on: https://code.wireshark.org/review/4221
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8605bbf   Restore the inclusion of request.cnf.c and response.cnf.c in the generated DCE/RPC MAPI dissector.
    adds  5e231d1   Fix wslua_filehandler_open() to work as wiretap open routines should.


Summary of changes:
 epan/wslua/wslua_file.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)