Wireshark · Wireshark-commits: [Wireshark-commits] master 8576e1c: Qt: Add stock icons.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8576e1c103cb0606d100c31b9794bcdb61bd50c6
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8576e1c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add stock icons.
    
    The new icons are patterned after the existing capture icons. They could
    probably benefit from some adjustments here and there.
    
    Start moving toward icon names and a directory layout compliant with
    freedesktop.org's Icon Naming Specification and Icon Theme
    Specification. We aren't fully compliant and might never be but anyone
    with exposure to FDO icon themes should at least know where everything
    is.
    
    Make Capture Start (x-capture-start) the first icon in the toolbar.
    
    Define the Colorize Packets, Auto Scroll, and zoom icons even though the
    Qt UI doesn't use them yet.
    
    Leave the Capture Filter, Display Filter, Coloring Rules, Preferences,
    and Help icons off for now. The GTK+ toolbar is overly cluttered and I'm
    not sure they're necessary.
    
    Try not to break ui/gtk/toolbar_icons.h.
    
    Remove welcome.qrc. I initially added it in case we needed to overlay
    the welcome screen with translucent .pngs but that never happened.
    
    To do:
    
    - Move the old GTK+ icons to their own directory.
    
    - Find a better name for the "toolbar" directory. "stock"?
    
    - Make the toolbar configurable.
    
    Change-Id: Ie07592113d307b8db786aedace672312a870fe38
    Reviewed-on: https://code.wireshark.org/review/4182
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  801824b   Add .travis.yml for Travis CI (for Github user...)
    adds  8576e1c   Qt: Add stock icons.


Summary of changes:
 Makefile.am                                        |  100 ++++++-
 configure.ac                                       |    1 +
 image/capture_start_24.png                         |  Bin 749 -> 0 bytes
 image/capture_start_active_24.png                  |  Bin 1086 -> 0 bytes
 image/capture_stop_24.png                          |  Bin 847 -> 0 bytes
 image/toolbar.qrc                                  |   57 +++-
 image/toolbar/16x16/edit-find.png                  |  Bin 0 -> 602 bytes
 image/toolbar/16x16/edit-find.svg                  |  120 ++++++++
 image/toolbar/16x16/go-first.png                   |  Bin 0 -> 579 bytes
 image/toolbar/16x16/go-first.svg                   |  295 +++++++++++++++++++
 image/toolbar/16x16/go-jump.png                    |  Bin 0 -> 574 bytes
 image/toolbar/16x16/go-jump.svg                    |  245 ++++++++++++++++
 image/toolbar/16x16/go-last.png                    |  Bin 0 -> 594 bytes
 image/toolbar/16x16/go-last.svg                    |  216 ++++++++++++++
 image/toolbar/16x16/go-next.png                    |  Bin 0 -> 550 bytes
 image/toolbar/16x16/go-next.svg                    |  207 ++++++++++++++
 image/toolbar/16x16/go-next.svg.png                |  Bin 0 -> 492 bytes
 image/toolbar/16x16/go-previous.png                |  Bin 0 -> 542 bytes
 image/toolbar/16x16/go-previous.svg                |  219 ++++++++++++++
 image/toolbar/16x16/x-capture-file-close.png       |  Bin 0 -> 341 bytes
 image/toolbar/16x16/x-capture-file-close.svg       |   98 +++++++
 image/toolbar/16x16/x-capture-file-reload.png      |  Bin 0 -> 779 bytes
 image/toolbar/16x16/x-capture-file-reload.svg      |  111 ++++++++
 .../x-capture-file-save.png}                       |  Bin 677 -> 677 bytes
 .../x-capture-options-gear.svg}                    |    0
 .../x-capture-options-wrench.svg}                  |    0
 .../x-capture-options.png}                         |  Bin 446 -> 446 bytes
 .../x-capture-restart-fin.svg}                     |    0
 .../x-capture-restart-triangle1.svg}               |    0
 .../x-capture-restart-triangle2.svg}               |    0
 .../x-capture-restart-turn1.svg}                   |    0
 .../x-capture-restart-turn2.svg}                   |    0
 .../x-capture-restart.png}                         |  Bin 687 -> 687 bytes
 .../x-capture-start.png}                           |  Bin 559 -> 559 bytes
 .../x-capture-start.svg}                           |    0
 .../x-capture-stop-red.svg}                        |    0
 .../x-capture-stop-white.svg}                      |    0
 .../x-capture-stop.png}                            |  Bin 140 -> 140 bytes
 image/toolbar/16x16/x-colorize-packets.png         |  Bin 0 -> 260 bytes
 image/toolbar/16x16/x-colorize-packets.svg         |  118 ++++++++
 image/toolbar/16x16/x-resize-columns.png           |  Bin 0 -> 629 bytes
 image/toolbar/16x16/x-resize-columns.svg           |  170 +++++++++++
 image/toolbar/16x16/x-stay-last.png                |  Bin 0 -> 389 bytes
 image/toolbar/16x16/x-stay-last.svg                |  135 +++++++++
 image/toolbar/16x16/zoom-in.png                    |  Bin 0 -> 596 bytes
 image/toolbar/16x16/zoom-in.svg                    |  118 ++++++++
 image/toolbar/16x16/zoom-original.png              |  Bin 0 -> 599 bytes
 image/toolbar/16x16/zoom-original.svg              |  117 ++++++++
 image/toolbar/16x16/zoom-out.png                   |  Bin 0 -> 586 bytes
 image/toolbar/16x16/zoom-out.svg                   |  110 +++++++
 image/toolbar/24x24/edit-find.png                  |  Bin 0 -> 825 bytes
 image/toolbar/24x24/edit-find.svg                  |  120 ++++++++
 image/toolbar/24x24/go-first.png                   |  Bin 0 -> 875 bytes
 image/toolbar/24x24/go-first.svg                   |  196 +++++++++++++
 image/toolbar/24x24/go-jump.png                    |  Bin 0 -> 802 bytes
 image/toolbar/24x24/go-jump.svg                    |  300 ++++++++++++++++++++
 image/toolbar/24x24/go-last.png                    |  Bin 0 -> 864 bytes
 image/toolbar/24x24/go-last.svg                    |  238 ++++++++++++++++
 image/toolbar/24x24/go-next.png                    |  Bin 0 -> 843 bytes
 image/toolbar/24x24/go-next.svg                    |  193 +++++++++++++
 image/toolbar/24x24/go-previous.png                |  Bin 0 -> 851 bytes
 image/toolbar/24x24/go-previous.svg                |  172 +++++++++++
 image/toolbar/24x24/x-capture-file-close.png       |  Bin 0 -> 477 bytes
 image/toolbar/24x24/x-capture-file-close.svg       |   99 +++++++
 image/toolbar/24x24/x-capture-file-reload.png      |  Bin 0 -> 1396 bytes
 image/toolbar/24x24/x-capture-file-reload.svg      |  112 ++++++++
 .../x-capture-file-save.png}                       |  Bin 1305 -> 1305 bytes
 .../x-capture-options-gear.svg}                    |    0
 .../x-capture-options-wrench.svg}                  |    0
 .../x-capture-options.png}                         |  Bin 621 -> 621 bytes
 .../x-capture-restart-fin.svg}                     |    0
 .../x-capture-restart-triangle1.svg}               |    0
 .../x-capture-restart-triangle2.svg}               |    0
 .../x-capture-restart-turn1.svg}                   |    0
 .../x-capture-restart-turn2.svg}                   |    0
 .../x-capture-restart.png}                         |  Bin 1140 -> 1140 bytes
 .../x-capture-start.png}                           |  Bin 934 -> 934 bytes
 .../x-capture-start.svg}                           |    0
 .../x-capture-stop-red.svg}                        |    0
 .../x-capture-stop-white.svg}                      |    0
 .../x-capture-stop.png}                            |  Bin 153 -> 153 bytes
 image/toolbar/24x24/x-colorize-packets.png         |  Bin 0 -> 274 bytes
 image/toolbar/24x24/x-colorize-packets.svg         |  132 +++++++++
 image/toolbar/24x24/x-resize-columns.png           |  Bin 0 -> 651 bytes
 image/toolbar/24x24/x-resize-columns.svg           |  188 ++++++++++++
 image/toolbar/24x24/x-stay-last.png                |  Bin 0 -> 491 bytes
 image/toolbar/24x24/x-stay-last.svg                |  149 ++++++++++
 image/toolbar/24x24/zoom-in.png                    |  Bin 0 -> 886 bytes
 image/toolbar/24x24/zoom-in.svg                    |  118 ++++++++
 image/toolbar/24x24/zoom-original.png              |  Bin 0 -> 900 bytes
 image/toolbar/24x24/zoom-original.svg              |  117 ++++++++
 image/toolbar/24x24/zoom-out.png                   |  Bin 0 -> 881 bytes
 image/toolbar/24x24/zoom-out.svg                   |  110 +++++++
 image/toolbar/capture_options_16.png               |  Bin 405 -> 0 bytes
 image/toolbar/capture_options_24.png               |  Bin 570 -> 0 bytes
... 129 lines suppressed ...