Wireshark-commits: [Wireshark-commits] master 10b33c0: Remove file_error() calls after pcap_read_bl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 18:54:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10b33c06de6d5ff7f60fcac2656f42b973da3420
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

10b33c0 by Guy Harris (guy@xxxxxxxxxxxx):

    Remove file_error() calls after pcap_read_block() calls.
    
    pcap_read_block() takes err and err_info arguments, and sets them on
    error; no need to call file_error() if pcap_read_block() fails.
    
    Change-Id: I33b96d31395bf7d66abdecbebd5cf775e8662004
    Reviewed-on: https://code.wireshark.org/review/4209
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  32c38a4   Add file_error() calls after file_read().
    adds  10b33c0   Remove file_error() calls after pcap_read_block() calls.


Summary of changes:
 wiretap/pcapng.c |    2 --
 1 file changed, 2 deletions(-)