Wireshark-commits: [Wireshark-commits] master-1.12 dd08f27: Add file_error() calls after file_read(
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 18:32:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd08f271ad7774f074da34598810016e738469b1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

dd08f27 by Guy Harris (guy@xxxxxxxxxxxx):

    Add file_error() calls after file_read().
    
    If file_read() doesn't return the exact number of bytes you asked for,
    and you really need all those bytes to be there, you have to call
    file_error() to find out what the problem is.
    
    Change-Id: I4cc87bc1b6cc5a49bbcbf93b56106f57af290d20
    Reviewed-on: https://code.wireshark.org/review/4205
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 32c38a4ecc7fc4f07349b0fbc13f7754be897546)
    Reviewed-on: https://code.wireshark.org/review/4206
    

Actions performed:

    from  34a6fc3   Set err_info if the attempts to read record headers fail.
    adds  dd08f27   Add file_error() calls after file_read().


Summary of changes:
 wiretap/nettl.c |    3 +++
 1 file changed, 3 insertions(+)