Wireshark-commits: [Wireshark-commits] master 3c55419: Set err_info if the attempts to read record
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 17:46:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c5541906b71736ecfcc6d89b31195d7c8e5d383
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3c55419 by Guy Harris (guy@xxxxxxxxxxxx):

    Set err_info if the attempts to read record headers fail.
    
    If it fails due to, for example, the file being gzipped and having a bad
    gzip CRC, the error returned is WTAP_ERR_DECOMPRESS and, for that error,
    err_info is expected to be set to a string giving details of the
    problem, so we need to pass back to our caller the string in question.
    
    Bug: 10484
    Change-Id: I3aa2a92d04fcc08946ff073a40efa708079bbb3e
    Reviewed-on: https://code.wireshark.org/review/4201
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  06237e4   proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.
    adds  3c55419   Set err_info if the attempts to read record headers fail.


Summary of changes:
 wiretap/libpcap.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)