Wireshark-commits: [Wireshark-commits] master-1.12 76c3193: Don't assert that values fit in 32 bits
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 01:41:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76c3193f06466208f49cd087c45c732ed431721c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

76c3193 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Don't assert that values fit in 32 bits if the NDR64 flag is set.
    
    For now, this just pacifies fuzz-testing.  If real world examples have this, there needs to be a drastic overhaul to support fields that could be either 32 or 64-bit values.
    
    Bug:9329
    Change-Id: I3e28808ca0291868a5f84258b0ee1e2a922703c2
    Reviewed-on: https://code.wireshark.org/review/4189
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit e489df5024acc86b0bd3c9f41844b06ff7560d24)
    Change-Id: I3e28808ca0291868a5f84258b0ee1e2a922703c2
    Reviewed-on: https://code.wireshark.org/review/4196
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1bfb1b5   Update debian/libwsutil4.symbols to match 1.12.1 ABI
    adds  76c3193   Don't assert that values fit in 32 bits if the NDR64 flag is set.


Summary of changes:
 epan/dissectors/packet-dcerpc-ndr.c    |    6 +--
 epan/dissectors/packet-dcerpc.c        |   67 +++++++++++++++++++++++---------
 epan/dissectors/packet-dcerpc.h        |    2 +-
 epan/dissectors/packet-dcom-oxid.c     |    4 +-
 plugins/profinet/packet-dcerpc-pn-io.c |   13 +++++--
 5 files changed, 65 insertions(+), 27 deletions(-)