Wireshark-commits: [Wireshark-commits] master 9fce9ba: Bluetooth: ACL/AVDTP: Fix ACL session handli
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Sep 2014 20:13:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9fce9ba18886cb13555697ced309e77d45d03ea5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9fce9ba by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: ACL/AVDTP: Fix ACL session handling
    
    In case like reusing "connection handle" number in next connection
    (2 -> 3 -> 2 again) AVDTP dissector does not properly dissected packets
    (it should be Signal, but dissect as Media).
    
    Add expert error to all packets that are not in ACL connection. This will
    show invalid packages (send after dissconnect), however incomplete
    (mostly beginning) connection will be marked too, but I think it have more
    pros than cons.
    
    Change-Id: I29cf706600cb12c8b93d0188dd2fba18dd5eba88
    Reviewed-on: https://code.wireshark.org/review/4167
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cbe7741   Update the documentation to use "Wireshark.pro".
    adds  9fce9ba   Bluetooth: ACL/AVDTP: Fix ACL session handling


Summary of changes:
 epan/dissectors/packet-btavdtp.c   |   22 ++++++++++++++++++----
 epan/dissectors/packet-bthci_acl.c |   29 ++++++++++++++++++++++-------
 2 files changed, 40 insertions(+), 11 deletions(-)