Wireshark-commits: [Wireshark-commits] master 3397618: Bluetooth: Fix some Clang Analyzer warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Sep 2014 16:15:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33976181a153a931a615d1c2331c26d2e0558076
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3397618 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: Fix some Clang Analyzer warnings
    
    Logic error Dereference of null pointer epan/dissectors/packet-bthci_acl.c 379
    Logic error Dereference of null pointer epan/dissectors/packet-bthci_acl.c 390
    Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 3673
    Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 1439
    Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 1662
    
    Thanks for Alexis La Goutte for pointing that.
    
    Change-Id: Ia646b33de9e368d32983efddfaa41edf7896d7fd
    Reviewed-on: https://code.wireshark.org/review/4165
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  051b000   fix-encoding-args.pl: Add a few fixups for FT_UINT_STRING
    adds  3397618   Bluetooth: Fix some Clang Analyzer warnings


Summary of changes:
 epan/dissectors/packet-bthci_acl.c |    2 ++
 epan/dissectors/packet-btsdp.c     |    6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)