Wireshark · Wireshark-commits: [Wireshark-commits] master 7e63805: Qt: Add the "Map" button to the Endpoints dialog.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e638057089bb9d599cd35d4673aef70e0ae58a1
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e63805 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add the "Map" button to the Endpoints dialog.
    
    Move the map creation code from ui/gtk/hostlist_table.c to
    ui/traffic_table_ui.c.
    
    Add CMake commands to copy ipmap.html to the run directory so that
    WIRESHARK_RUN_FROM_BUILD_DIRECTORY works for the endpoint map. Not sure
    if they're entirely correct but they appear to work.
    
    Add boundary checkes to geoip_db_lookup_ipv[46].
    
    To do:
    
    - It looks like there are prettier maps and newer APIs that we
      might want to use.
    
    Change-Id: Ie06992c9bc9c9aa683328aecab3f5f69c9cab966
    Reviewed-on: https://code.wireshark.org/review/4011
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  478fab5   Qt: Remove duplicate GeoIP columns.
    adds  7e63805   Qt: Add the "Map" button to the Endpoints dialog.


Summary of changes:
 CMakeLists.txt                 |   74 +++++++-----
 epan/geoip_db.c                |    6 +
 ui/gtk/hostlist_table.c        |  247 +++-------------------------------------
 ui/qt/conversation_dialog.h    |    1 -
 ui/qt/endpoint_dialog.cpp      |   49 +++++++-
 ui/qt/endpoint_dialog.h        |   16 ++-
 ui/qt/traffic_table_dialog.cpp |    4 +-
 ui/qt/traffic_table_dialog.h   |    2 +-
 ui/traffic_table_ui.c          |  222 ++++++++++++++++++++++++++++++++++++
 ui/traffic_table_ui.h          |   13 +++
 10 files changed, 364 insertions(+), 270 deletions(-)