Wireshark-commits: [Wireshark-commits] master b5296f4: Use tvb_new_subset_length() rather than tvb_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Sep 2014 21:30:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5296f465e805eb8529f5856641f3b03357e8367
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b5296f4 by Guy Harris (guy@xxxxxxxxxxxx):

    Use tvb_new_subset_length() rather than tvb_new_subset().
    
    We rarely, if ever, want to, or need to, explicitly set the captured
    length of a packet; we want to set the *reported* length and let the
    tvbuff code figure out how much of that data was actually captured.
    
    Change-Id: I9b93d296197989f677d888b10954589dfc1edc59
    Reviewed-on: https://code.wireshark.org/review/4138
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1cbd9c7   Fix compilation in weird cases
    adds  b5296f4   Use tvb_new_subset_length() rather than tvb_new_subset().


Summary of changes:
 epan/proto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)