Wireshark-commits: [Wireshark-commits] master fee9277: Fix some logically dead code reported by Cov
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Sep 2014 00:40:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fee9277d76d507d276ad9875eae2bc716341e446
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fee9277 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Fix some logically dead code reported by Coverity (CIDs 1158807, 1158808, 1229737).
    
    Replace some conditional + fprintf + DISSECTOR_ASSERT()s with
    DISSECTOR_ASSERT_HINT() or just change the DISSECTOR_ASSERT() to
    DISSECTOR_ASSERT_NOT_REACHED() when the hint requires formatting.
    
    Change-Id: I80c7c6579d7755a60d644b5ef60ec4e3299ba0ab
    Reviewed-on: https://code.wireshark.org/review/4115
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    

Actions performed:

    from  126b4a6   expert.[hc] Minor changes:
    adds  fee9277   Fix some logically dead code reported by Coverity (CIDs 1158807, 1158808, 1229737).


Summary of changes:
 epan/proto.c |   24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)