Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 b429020: Don't try to set the length, end, or text of a faked item.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b429020228e39729510c3f8ece91db46c451090c
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b429020 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't try to set the length, end, or text of a faked item.
    
    If we try we may (in the case of setting the length or end) mistakenly assert
    out.
    
    Bug: 10329
    Change-Id: I52083ba17f6427712a6a363f48f1f7ae51f2b74b
    Reviewed-on: https://code.wireshark.org/review/4093
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit af9d2dfa134eecf420fa5a9589e032db2909fe0d)
    Reviewed-on: https://code.wireshark.org/review/4111
    

Actions performed:

    from  4bd2382   Revert "Only fake an item by returning 'tree' if they use the same TVB"
    adds  b429020   Don't try to set the length, end, or text of a faked item.


Summary of changes:
 epan/proto.c |   31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)