Wireshark · Wireshark-commits: [Wireshark-commits] master 21adbaa: Don't use the captured length, and don't fetch the version until

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21adbaa052ee083f8ef9a971bf3954db9d777f6f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

21adbaa by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use the captured length, and don't fetch the version until we need it.
    
    The captured length reflects the way the capture was done; it should not
    affect actual lengths used in the dissection.
    
    Don't fetch the version until we need it; that lets us dissect more of
    the packet if the previous change caused us to throw an exception trying
    to fetch the version from the correct location rather than not throwing
    an exception by fetching it from an incorrect location that happens to
    be within the captured data.
    
    Change-Id: I9f63afd4ef51f46c19b3afd2a651a5bb768fecaf
    Reviewed-on: https://code.wireshark.org/review/4101
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1277839   Clean up indentation.
    adds  21adbaa   Don't use the captured length, and don't fetch the version until we need it.


Summary of changes:
 asn1/ldap/packet-ldap-template.c |   28 ++++++++++++++++------------
 epan/dissectors/packet-ldap.c    |   34 +++++++++++++++++++---------------
 2 files changed, 35 insertions(+), 27 deletions(-)