Wireshark-commits: [Wireshark-commits] master-1.12 4a5c80b: Don't print non-printable characters in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Sep 2014 19:18:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a5c80ba68e0eafa6418083995b9fd17e88cbae8
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4a5c80b by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't print non-printable characters in AX.25 addresses.
    
    Add a new routine to wsutil to make this easy: printable_char_or_period().
    
    Bug: 10439
    Change-Id: I0eb2bb6bc0676a1035c3d845b5e20276fa04de60
    Reviewed-on: https://code.wireshark.org/review/3981
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 2497482e34a108275f75cd8106e1841b35aab98e)
    Change-Id: I0eb2bb6bc0676a1035c3d845b5e20276fa04de60
    Reviewed-on: https://code.wireshark.org/review/3985
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  c4421f1   packet-cfm.c: Fix Bug 10385: "Ethernet OAM (CFM) frames including TLV's are wrongly decoded as malformed"
    adds  4a5c80b   Don't print non-printable characters in AX.25 addresses.


Summary of changes:
 epan/address_to_str.c |    9 +++++++--
 wsutil/str_util.c     |   10 +++++++++-
 wsutil/str_util.h     |    2 ++
 3 files changed, 18 insertions(+), 3 deletions(-)