Wireshark-commits: [Wireshark-commits] master 29993d5: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Sep 2014 06:33:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29993d5266ff0a19d0d49a19a0473d7bb17cda43
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29993d5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Change-Id: Ie41ac30f8edaeee75b23717ef1d5147d804a65b3
    Reviewed-on: https://code.wireshark.org/review/4074
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d5940f5   Clarify that 16777229 is the AppID for 3GPP Rx Release 6.
    adds  29993d5   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-3g-a11.c       |   65 ++++++++++++-----------
 epan/dissectors/packet-acn.c          |   88 ++++++++++++++++++++++---------
 epan/dissectors/packet-adwin-config.c |   92 ++++++++++++++++++++------------
 epan/dissectors/packet-adwin.c        |   61 +++++++++++++--------
 epan/dissectors/packet-aim-admin.c    |   14 +++--
 epan/dissectors/packet-aim-chat.c     |   17 +++---
 epan/dissectors/packet-aim-generic.c  |   93 ++++++++++++++++++++-------------
 epan/dissectors/packet-amr.c          |   62 ++++++++++++++--------
 epan/dissectors/packet-arp.c          |    8 +--
 epan/dissectors/packet-atalk.c        |   74 ++++++++------------------
 epan/dissectors/packet-beep.c         |    8 ++-
 11 files changed, 342 insertions(+), 240 deletions(-)