Wireshark-commits: [Wireshark-commits] master cf8f11f: Eliminate proto_tree_add_text from some of t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Sep 2014 15:46:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf8f11f67876462510cc4254b845063c6cc047de
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cf8f11f by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some of the dissectors.
    
    Other minor cleanups while in the area.
    
    Change-Id: I623d941e53128f169e55dfc629547b4221fa72fc
    Reviewed-on: https://code.wireshark.org/review/4021
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  433a444   ses: initialize pres_ctx_id in session struct
    adds  cf8f11f   Eliminate proto_tree_add_text from some of the dissectors.


Summary of changes:
 epan/dissectors/packet-t30.c      |    4 +-
 epan/dissectors/packet-tftp.c     |    8 +++-
 epan/dissectors/packet-time.c     |   13 ++++--
 epan/dissectors/packet-tn3270.c   |   87 ++++++++++++++++++-----------------
 epan/dissectors/packet-tn5250.c   |   73 ++++++++++-------------------
 epan/dissectors/packet-tpkt.c     |   21 ++++++---
 epan/dissectors/packet-tpncp.c    |   27 +++++------
 epan/dissectors/packet-tr.c       |   27 ++++++++---
 epan/dissectors/packet-ua.c       |   16 +++----
 epan/dissectors/packet-udld.c     |   91 +++++++++++++++++++++++--------------
 epan/dissectors/packet-umts_fp.c  |    6 +--
 epan/dissectors/packet-usb-ccid.c |   16 ++++---
 epan/dissectors/packet-usb-hid.c  |    6 +--
 epan/dissectors/packet-vicp.c     |    5 +-
 epan/dissectors/packet-vines.c    |   17 +++++--
 epan/dissectors/packet-vnc.c      |   41 +++++++++++------
 epan/dissectors/packet-vp8.c      |   20 +++++---
 epan/dissectors/packet-vtp.c      |   19 ++++++--
 18 files changed, 282 insertions(+), 215 deletions(-)