Wireshark-commits: [Wireshark-commits] master 2c9af79: openSAFETY: Add datafield for preload
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Sep 2014 13:42:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c9af798f2c6af425eb24adec7da971e9dc7c1d1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2c9af79 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Add datafield for preload
    
     - Block Up-/Download will be removed from the protocol
       It has never been implemented => no impact
     - Preload will be added in future versions of the
       openSAFETY specification
     - Better definition of SSDO ACMD sets to ensure correct
       protocol dissection
     - Use TFS.h t/f strings where applicable, remaining
       strings are referenced directly from specification
    
    Change-Id: I9c809098938333c914e1f8ba67d100b994fd33f4
    Reviewed-on: https://code.wireshark.org/review/2647
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1c1f187   s7comm: Add dissector for S7 Communication
    adds  2c9af79   openSAFETY: Add datafield for preload


Summary of changes:
 epan/dissectors/packet-opensafety.c |  198 ++++++++++++++++++-----------------
 1 file changed, 103 insertions(+), 95 deletions(-)