Wireshark-commits: [Wireshark-commits] master 1a44607: Simplify ./configure logic for telling rpmbu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 2 Sep 2014 16:34:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a446079d13dae8e4d286677b0458b15558d185d
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a44607 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Simplify ./configure logic for telling rpmbuild which GUI(s) we're building.
    
    Rather than checking for all the "--with" arguments just use the "$have_xxx"
    variables.
    
    Don't allow rpmbuild's ./configure to decide to build a GUI just because it's
    available: make it build only what was ./configure'd.
    
    Change-Id: I68582b4c13da7b52d56591dce68ac426e9f607f1
    Reviewed-on: https://code.wireshark.org/review/3958
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  b7fb116   Qt → wireshark. GTK+ → wireshark-gtk.
    adds  1a44607   Simplify ./configure logic for telling rpmbuild which GUI(s) we're building.


Summary of changes:
 configure.ac                          |   54 +++++++++++----------------------
 packaging/rpm/SPECS/wireshark.spec.in |   18 +++++++++--
 2 files changed, 32 insertions(+), 40 deletions(-)