Wireshark-commits: [Wireshark-commits] master b9e61be: RTPS: added new PIDs and included minor impr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 2 Sep 2014 02:43:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9e61becffc42f4b2d7981a0f468effbe9fa4b12
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b9e61be by Juanjo (juanjo@xxxxxxx):

    RTPS: added new PIDs and included minor improvements
    - (Updated) Fixed code review issues
    - (Updated) Fixed whitespaces and code review issues
    - Representing now some NTP times as duration (not as date)
    - Added some vendor specific PIDs (RTI)
    - Added dissect_APP_ACK_CONF, dissect_APP_ACK and
      dissect_HEARTBEAT_VIRTUAL
    - Added is_discovery to dissect_serialize_data to avoid malformed
      packets when using mutable types (Wireshark assumes serialized
      data with CDR-PL encapsulation is always discovery data, what
      is not true when using Mutable types)
    
    Change-Id: I491750d95b12f386c41d7de4ae7e280781efa375
    Reviewed-on: https://code.wireshark.org/review/3836
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  db6f197   openSAFETY: Adapt CRC for false-positives
    adds  b9e61be   RTPS: added new PIDs and included minor improvements - (Updated) Fixed code review issues - (Updated) Fixed whitespaces and code review issues - Representing now some NTP times as duration (not as date) - Added some vendor specific PIDs (RTI) - Added dissect_APP_ACK_CONF, dissect_APP_ACK and   dissect_HEARTBEAT_VIRTUAL - Added is_discovery to dissect_serialize_data to avoid malformed   packets when using mutable types (Wireshark assumes serialized   data with CDR-PL en [...]


Summary of changes:
 epan/dissectors/packet-rtps.c | 1895 ++++++++++++++++++++++++++++++++++-------
 epan/dissectors/packet-rtps.h |   77 +-
 2 files changed, 1678 insertions(+), 294 deletions(-)