Wireshark · Wireshark-commits: [Wireshark-commits] master db6f197: openSAFETY: Adapt CRC for false-positives

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db6f197c962200e0be717b953c0ebe7d7c908bf1
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

db6f197 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Adapt CRC for false-positives
    
     - There are rare false-positives, where the entire
       frame consists of 0 except the addr and id field,
       which will lead to a correct crc#1 calculation,
       but still to a false-positive detection. This
       patch fixes that
    
     - Two undefinite-loop errors are corrected as well
    
    Change-Id: Ibe5e56e0172ad3a3046bdc024da3711987116e8e
    Reviewed-on: https://code.wireshark.org/review/3918
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  9ee7c38   NDMP: Fix Dereference of null pointer found by Clang analyzer
    adds  db6f197   openSAFETY: Adapt CRC for false-positives


Summary of changes:
 epan/dissectors/packet-opensafety.c |  129 +++++++++++++++++++++--------------
 1 file changed, 76 insertions(+), 53 deletions(-)