Wireshark-commits: [Wireshark-commits] master c361211: simplify dissect_nonstandard_usb_setup_reque
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Aug 2014 19:14:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c36121100795ca2f0ab65cf2dc9171a69347b27a
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c361211 by Martin Kaiser (wireshark@xxxxxxxxx):

    simplify dissect_nonstandard_usb_setup_request()
    create setup_tvb in the calling function
    
    Change-Id: Id34635afbd25817b09535fc52d1ba396b2597e5a
    Reviewed-on: https://code.wireshark.org/review/3900
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  6603ac9   correct detection of USB header type this fixes a regression for linux USB headers without 64 bytes extension
    adds  c361211   simplify dissect_nonstandard_usb_setup_request() create setup_tvb in the calling function


Summary of changes:
 epan/dissectors/packet-usb.c |   45 ++++++++++++++++++------------------------
 1 file changed, 19 insertions(+), 26 deletions(-)