Wireshark-commits: [Wireshark-commits] master-1.12 4872e8a: NTP: fix parsing of control assignments
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Aug 2014 07:21:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4872e8a4dddbcb18723f4b1ad48b41097c8b7b20
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4872e8a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NTP: fix parsing of control assignments with empty value
    
    Consider that ',' is a separator between assignments and make value presence optional
    
    Bug: 10417
    Change-Id: I23f2b4029548a1263d65ee11c6356270e7a89bd7
    Reviewed-on: https://code.wireshark.org/review/3884
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit edcd2dd57f1649dbb25f1ad0f4a3a77c4d454322)
    Reviewed-on: https://code.wireshark.org/review/3889
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  fa483e6   Increase the error buffer size for rpcap.
    adds  4872e8a   NTP: fix parsing of control assignments with empty value


Summary of changes:
 epan/dissectors/packet-ntp.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)