Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 fa483e6: Increase the error buffer size for rpcap.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa483e652110f1e7f812f252eb7dcab75ec891e3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

fa483e6 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Increase the error buffer size for rpcap.
    
    If the rpcap port is unreachable pcap_findalldevs_ex can write more
    than PCAP_ERRBUF_SIZE bytes to errbuf. E.g. if we try to capture from
    Google's all-eights public DNS server we get:
    
    ----
    Can't get list of interfaces: Is the server properly installed on 8.8.8.8?
    connect() failed: A connection attempt failed because the connected
    party did not properly respond after a period of time, or established
    connection failed because connected host has failed to respond.  (code 1
    ----
    
    Set the buffer to PCAP_ERRBUF_SIZE*4 bytes. Hopefully that's large enough.
    
    Change-Id: I19f34cda16050c1ba8b9d7d6ed2d8e77b945a2af
    Ping-Bug: 3554
    Ping-Bug: 6922
    Ping-Bug: 7021
    Reviewed-on: https://code.wireshark.org/review/3880
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 5ee328e90b26f82fbd00316110c5edd9a5c852e6)
    Reviewed-on: https://code.wireshark.org/review/3886
    

Actions performed:

    from  dfc005a   Hack to fix RTP player progress line position
    adds  fa483e6   Increase the error buffer size for rpcap.


Summary of changes:
 capture-pcap-util.c            |    8 ++++++--
 docbook/release-notes.asciidoc |    2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)