Wireshark-commits: [Wireshark-commits] master 8fee04a: USB: fix dissection of non standard USB setu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Aug 2014 13:50:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8fee04ab512e957f3e5a1bc371fe4601eb8ba5a9
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8fee04a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    USB: fix dissection of non standard USB setup requests
    
    Otherwise captures like the one found in bug 8161 do not dissect properly anymore (sub dissector is called twice)
    
    While we are at it, reorganize functions order to void a forward declaration
    
    Change-Id: Id02ef835ba24981902a1702f976db099fa07b0fd
    Reviewed-on: https://code.wireshark.org/review/3858
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  ff59722   USB: get rid of the remaining proto_tree_add_text instances
    adds  8fee04a   USB: fix dissection of non standard USB setup requests


Summary of changes:
 epan/dissectors/packet-usb.c |   93 +++++++++++++++++++-----------------------
 1 file changed, 43 insertions(+), 50 deletions(-)