Wireshark-commits: [Wireshark-commits] master 7749263: Skinny Dissector:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Aug 2014 23:58:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7749263be6b34dbdb0e1869d55d80ace9d1ef593
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7749263 by Diederik de Groot (ddegroot@xxxxxxxx):

    Skinny Dissector:
    
    Source Fix: Trailing Whitespace (Reported by Graham Bloice).
    Dissection Fix: ProtocolVer needed to be split up into two fields to display the protocol version correct during device registration
    Segfault Fix: Null Pointer Check required after returning from tvb_memdup, before calling strlen (Reported by Evan Huus)
    Fix: Whitespace (again)
    
    Bug: 10409
    Change-Id: Ib253ea843363792f678f2e724359f83f12ebfadc
    Reviewed-on: https://code.wireshark.org/review/3844
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  1c98a12   WSUG_chapter_capture is now an asciidoc file that gets converted into an xml file.
    adds  7749263   Skinny Dissector:


Summary of changes:
 epan/dissectors/packet-skinny.c    |   53 ++++++++++++++++++++++++++++--------
 epan/dissectors/packet-skinny.c.in |    7 ++++-
 epan/dissectors/packet-skinny.h.in |    3 +-
 tools/SkinnyProtocolOptimized.xml  |   28 +++++++++++++++++--
 4 files changed, 74 insertions(+), 17 deletions(-)