Wireshark-commits: [Wireshark-commits] master b737e2e: remove trans_info parameter from dissect_usb
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Aug 2014 13:59:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b737e2e8ef9540659d2918653fd9805a16fbb3c5
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b737e2e by Martin Kaiser (wireshark@xxxxxxxxx):

    remove trans_info parameter from dissect_usb_endpoint_descriptor()
    (remove it in the call from mausb as well)
    
    add NULL checks for usb_conv_info, usb_trans_info
    
    Change-Id: I95d52b85e3fa0d42b6a20047053259aaca8754fe
    Reviewed-on: https://code.wireshark.org/review/3784
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  c284e12   remove trans_info parameter from dissect_usb_unknown_descriptor() remove now unused trans_info variable in mausb
    adds  b737e2e   remove trans_info parameter from dissect_usb_endpoint_descriptor() (remove it in the call from mausb as well)


Summary of changes:
 epan/dissectors/packet-mausb.c |    2 +-
 epan/dissectors/packet-usb.c   |   31 +++++++++++++++++--------------
 epan/dissectors/packet-usb.h   |    3 +--
 3 files changed, 19 insertions(+), 17 deletions(-)