Wireshark-commits: [Wireshark-commits] master 276a697: [RFC] Skinny: Rewrite using automatic code g
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 24 Aug 2014 12:55:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=276a697a6b57205f15975e6e740bd427b7b510d1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

276a697 by Diederik de Groot (ddegroot@xxxxxxxx):

    [RFC] Skinny: Rewrite using automatic code generation
    
    Support: Protocolversion 0 - 22
    Includes: Callmanager to/from Cisco Phones, Inter CallManager Messages and CallManager to/from Cisco ASA
    Code Generator not included, because protocol does not evolve anymore / No newer versions to be expected
    Fixed: Added more readable information for SoftKeyTemplateRes and SoftKeySetRes, Added Bitfield processing, Added Longer Field Descriptions
    Fixed: message_handle array overrun, message_ids, hf_skinny fields format
    Fixed: dialedNumber Message, Setting data on si->fields (tap.h)
    Fixed: Comments made by Peter Wu
    Added: Code Generator Sources
    Fixed: hf_skinny blurp, XML Truncation, Updated ButtonTemplate, SoftKeyTemplate and SoftKeyRes presentation
    Fixed: EnblocMessage, DialedNumberMessage
    Added: DisplayLabels
    Added: dissect_skinny_DisplayLabel function to Lookup and Translate in the phone embedded strings to human readable form
    Fixed: CallInfoV2, OpenReceiveChannelAck, KeypadButton when generated by a 7912 running old firmware.
    Fixed: Made changes requested by Peter Wu, in last 2 reviews
    Fixed: ConfigStatV2, ServerRes
    Fixed: Comment made by Michael Mann
    Fixed: CheckAPI.pl / Petri Dish
    Fixed: Included packet-skinny.h and epan/dissectors/packet-skinny.h.in -> Petri Dish
    
    Change-Id: Ic2d2ead8ff0ce80668c9b2e249ce69f53e25a383
    Bug: 10262
    Reviewed-on: https://code.wireshark.org/review/2921
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cda5c16   Clean up capinfos output.
    adds  276a697   [RFC] Skinny: Rewrite using automatic code generation


Summary of changes:
 epan/dissectors/packet-skinny.c                    |14263 +++++++++++++-------
 epan/dissectors/packet-skinny.c.in                 |  559 +
 epan/dissectors/packet-skinny.h                    |    3 +
 .../{packet-skinny.h => packet-skinny.h.in}        |    3 +
 tools/SkinnyProtocolOptimized.xml                  | 4062 ++++++
 tools/parse_xml2skinny_dissector.py                |  888 ++
 6 files changed, 14780 insertions(+), 4998 deletions(-)
 create mode 100644 epan/dissectors/packet-skinny.c.in
 copy epan/dissectors/{packet-skinny.h => packet-skinny.h.in} (92%)
 create mode 100644 tools/SkinnyProtocolOptimized.xml
 create mode 100755 tools/parse_xml2skinny_dissector.py